-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronization updates #416
Conversation
* JRuby broken for now
fix usages of #ensure_ivar_visibility!
9b8a280
to
bfee210
Compare
Looks great so far! Any idea when this will be ready to merge? |
f246879
to
0bd741c
Compare
Unless I run into issues, it should be merged in few days. |
I am doing one more biggish change around |
Changes to discuss:
|
We cannot require Java 8. As discussed here, JRuby 9000 supports both Java 7 and Java 8. That's why we are still using the internal implementation of ConcurrentHashMap (imported from thread_safe) rather than the Java 8 implementation. |
This is related to conversation in #357 too. I was remembering it wrong and I thought we are going to drop Java 8 support. I'll put the "best effort" hack for java 7 back and I'll keep working on this after rc. @jdantonio sorry that it takes so long. |
f778dbb
to
69c014d
Compare
At one point we talked about dropping Java 7 support but then Rails happened and @thedarkone reminded us of the need to support Java 7. |
…sibility! * ensures full memory barier is inserted only when needed * ensures that it's inserted only once * testable correctness with @FinalIvar convention
69c014d
to
ad8fde2
Compare
ad8fde2
to
7b03abb
Compare
I've added the two tests that failed to my list of buggy tests. They aren't related to this PR. @pitr-ch Is this ready to merge? The docs aren't necessary for a pre-release. |
Ok, I'll check the bug on travis, and I'll merge today. |
Cool. Once that's done I'll create the next pre-release and submit the thread_safe replacement PR to Rails. Thank you! |
@jdantonio Thanks for your patience. |
I've published a new pre-release and submit the PR to Rails which replaced thread_safe. That PR was merged. My priorities for 1.0 are interpreter warnings, buggy tests, and documentation. None of that will get in the way of your continued work on synchronization. We're almost there! :-) |
Thank you! I'll focus on the documentation for the layer. |
Work in progress, todo: