Skip to content
This repository was archived by the owner on Dec 1, 2023. It is now read-only.

Development #9

Merged
merged 5 commits into from
Nov 11, 2019
Merged

Development #9

merged 5 commits into from
Nov 11, 2019

Conversation

cleygraf
Copy link
Contributor

@cleygraf cleygraf commented Nov 5, 2019

Description

  • Fixed an issue with guest os credentials
  • Added some more tests
  • Increased verbosity a little bit

Motivation and Context

  • Fixed an issue with guest os credentials
    => get it run on my and customers machines

  • Added some more tests
    => Test of a port is open on the test vm (port 80 as an example)
    => Test for services to run on the test vm (NTDS and SQL-Server as an example)

  • Increased verbosity a little bit
    => Make it easier to troubleshoot in a new environment

How Has This Been Tested?

  • Tested on PowerShell core on Mac and Windows
  • Tested on PowerShell on Windows

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

cleygraf and others added 5 commits November 5, 2019 09:14
Powershell Core on Mac/LINUX requires a different cmdlet to test if a port is open and reachable.
@jaapbrasser
Copy link
Contributor

Thanks for your contribution @cleygraf, I'll review your code and get this merged in

Copy link
Contributor

@jaapbrasser jaapbrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, looks good.

@jaapbrasser
Copy link
Contributor

Thanks for your contribution @cleygraf, @Spacemonkey-se also detected this same bug you resolved for the validatescript task.

@jaapbrasser jaapbrasser merged commit 980b38d into rubrikinc:master Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants