New script for installing RBS with RSC #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerobinson
approved these changes
Mar 12, 2024
| param( | ||
| # Rubrik Cluster name or ip address | ||
| [Parameter(Mandatory=$true)] | ||
| [string]$RubrikCluster, |
There was a problem hiding this comment.
RubrikCluster would indicate to me this is a Rubrik cluster object.
There was a problem hiding this comment.
specifically, I'd rather see this be an actual object input, or name change the parameter to RubrikClusterName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install-RSCRubrikBackupService.ps1 is a new script that will install the RBS via RSC instead of CDM. The script will use DSC to configure the service and local administrators group.