migrate GitHub managed runner to an internal one #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for semver version strings
Toolkit test fixes
Summary: The updated Get-RscNasSystem command will have following functionality. 1. Get-RscNasSystem should return all NAS systems from the API. (Max Page size is 50) 2. Get-RscNasSystem -id "12345..." should return the NAS system with the specified ID. 3. Get-RscNasSystem -name "foo" should filter on NAS systems with the name of “foo” (Max Page size is 50) 4. Get-RscNasSystem -first 3 should return first 3 NAS systems 5. Get-RscNasSystem -name “foo” -first 3 should return first 3 NAS systems with name “foo” Test Plan: -> Conducted manual testing by invoking Get-RscNasSystem for various scenarios. -> Added e2e tests for Get-RscNasSystem JIRA: SPARK-439652 Revert Plan: NA
…d-id Get-RscNasSystem: Remove forced requirement of -id
Summary:
-> Fetches existing SLA values from the Sla input
parameter or via pipeline support, making the
Sla parameter mandatory.
-> Enhances support to set all SLA fields not
provided as parameters to their existing
values.
-> Removes the Id parameter.
Test Plan:
Conducted manual testing by invoking Set-RscSla on an
existing SLA on ui.dev and ensure that all
non-provided fields are set to their
existing values.
JIRA:
SPARK-330821
Revert Plan:
NA
Summary: 1. Running Get-RscNasShare should return all NAS shares from the API. 2. Running Get-RscNasShare -Id "12345..." should return the NAS share with the specified ID. 3. Running Get-RscNasShare -name "foo" should filter on NAS shares with the name of “foo” 4. Running Get-RscNasSystem -name "bar" | Get-RscNasShare should return all shares from the NAS system “foo” -> Corrected Prameter Doc for `Get-RscNasSystem` Test Plan: -> Written e2e tests for the above scenarios Jira: SPARK-439654 Revert Plan: NA
Cmdlet fixes and additions
Updated Set-RscSla to retain existing values for non-provided fields
Get-RscNasShare Filtering Updates
Get-RscWorkload updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rubrik.atlassian.net/browse/SPARK-422108