Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the eks version when approving a bundle #132

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ansh121
Copy link
Contributor

@ansh121 ansh121 commented Nov 22, 2024

There is one small bug in the pcr script. We need the EKS version when launching exocompute cluster. We are making this field mandatory for all customers. Making the change here as well since most of the customer use this script for PCR setup.

Doc: https://rubrikinc.github.io/rubrik-api-documentation/use-cases/cloud-native-private-container-registry/

Copy link
Contributor

@DamaniN DamaniN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DamaniN
Copy link
Contributor

DamaniN commented Nov 22, 2024

@pmilano1 and @leitzler, Can you take a look at the tests in this PR and see why they are failing? It seems to be a framework issue, and preventing us from publishing the PR. Other PRs on this repo may be having the same.

@guirava guirava merged commit e744f56 into rubrikinc:beta Nov 29, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants