Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure VM protection permission set #4

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

shubhamaggarwal-rubrik
Copy link
Contributor

Description

This PR adds the permission set required for Basic Azure VM protection in the new format.

Related Issue

This project only accepts pull requests related to open issues.

  • If suggesting a new feature or change, please discuss it in an issue first.
  • If fixing a bug, there should be an issue describing it with steps to reproduce

Please link to the issue here

Motivation and Context

Why is this change required? What problem does it solve?

@shubhamaggarwal-rubrik shubhamaggarwal-rubrik force-pushed the azure-format-permissions branch 3 times, most recently from 8f3e981 to 55193c6 Compare July 26, 2023 17:30
@shubhamaggarwal-rubrik shubhamaggarwal-rubrik changed the title Add basic Azure VM protection permission set Add Azure VM protection permission set Jul 26, 2023
[
{
"Actions": [
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename this to permission-group-basic.json
We use permission group term everywhere and it would be good to stick to a single terminology. Can you also rename other file accordingly.

@shubhamaggarwal-rubrik shubhamaggarwal-rubrik force-pushed the azure-format-permissions branch 2 times, most recently from 5e1b9a5 to d524252 Compare July 29, 2023 09:01
@shubhamaggarwal-rubrik shubhamaggarwal-rubrik merged commit 735eb89 into master Aug 2, 2023
@shubhamaggarwal-rubrik shubhamaggarwal-rubrik deleted the azure-format-permissions branch August 2, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants