Add entry for No Mutable Defaults #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8 tasks
pirj
reviewed
Nov 29, 2024
Avoid the use of shared mutable objects as hash default values. Complements: rubocop/rubocop#13463 Up
corsonknowles
force-pushed
the
add_entry_for_shared_mutable_defaults
branch
from
41fb457 to
3b7c969
Compare
andyw8
reviewed
Nov 30, 2024
| Hash.new(Array.new) | ||
| Hash.new(Hash.new) | ||
|
|
||
| # okay -- beware this will silently discard mutations and only remember assignments |
There was a problem hiding this comment.
Are there any legitimate uses for this? Can we say 'probably bad' instead of 'okay'?
This can be discussed in rubocop/rubocop#13463 instead.
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the use of shared mutable objects as hash default values.
Complements: rubocop/rubocop#13463