Remove extracted cops in Capybara, FactoryBot and Rails departments.
#1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
changed the title
Capybara, FactoryBot, Rails)Capybara, FactoryBot and Rails departments.
pirj
reviewed
Mar 30, 2024
| VersionAdded: '1.18' | ||
| VersionChanged: '2.0' | ||
| Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation | ||
|
|
||
| RSpec/Capybara/FeatureMethods: |
There was a problem hiding this comment.
Can we replace featuremethods with RSpec/Dialect configuration?
Would close a bunch of issues, too:
There was a problem hiding this comment.
Good idea @pirj. I’ve added this as an issue in the 3.0 milestone.
|
@ydah Now that we have a separate |
bquorning
reviewed
May 3, 2024
5 tasks
|
I updated this PR. |
|
It is also a blocker for subsequent PR, so this PR will be merged. We can also follow up. |
h-lame
added a commit
to meetcleo/apipie-rails
that referenced
this pull request
Jul 5, 2024
In rubocop/rubocop-rspec#1848 rubocop-rspec extracted some cops to separate gems, and because we referenced one of them in our rubocop_todo.yml the whole rubocop process wouldn't run because it doesn't like config for cops it doesn't know about. We introducing the missing gem, `rubocop-rspec_rails`, and fix the name in the config to let us run rubocop again. There is one infraction that exists in the source so we fix that to get us to a green rubocop run.
mathieujobin
pushed a commit
to Apipie/apipie-rails
that referenced
this pull request
Jul 9, 2024
#939) * Update how we use Rack::Utils to get status codes As part of rack/rack#2137 (released in Rack 3) Rack changed the values of `Rack::Utils::SYMBOL_TO_STATUS_CODE` so asking for `:unprocessable_entity` now returns `nil`. The guidance has always been to use `Rack::Util.status_code` (present in the API since Rack 1.1) so let's just do that. * Handle a missing `rack.input` in the env Ever since rack/rack#2018 `rack.input` has been optional so we can't assume it's there and call `read` or `rewind` on it in `Apipie::Extractor::Recorder`. Using safe navigation to call these methods seems like the simplest approach because we want to look for `rack.request.form_hash` instead in both the situation where `rack.input` is missing, or it's empty. * Add rubocop-rspec_rails and get rubocop run to green In rubocop/rubocop-rspec#1848 rubocop-rspec extracted some cops to separate gems, and because we referenced one of them in our rubocop_todo.yml the whole rubocop process wouldn't run because it doesn't like config for cops it doesn't know about. We introducing the missing gem, `rubocop-rspec_rails`, and fix the name in the config to let us run rubocop again. There is one infraction that exists in the source so we fix that to get us to a green rubocop run. * Only add rubocop-rspec_rails for ruby >-= 2.7 It's only available for 2.7+ and we still run this build on 2.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove extracted cop departments. (
Capybara,FactoryBot,Rails)Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).