Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented May 24, 2021

Follow rubocop/rubocop#8930 and rubocop/rubocop@3fc75c4.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the add_alternative_changelog_building branch from 3c1b1d6 to 0af324c Compare May 24, 2021 04:48
@koic koic merged commit 83d7817 into rubocop:master May 27, 2021
@koic koic deleted the add_alternative_changelog_building branch May 27, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant