Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Sep 11, 2025

This PR fixes an incorrect autocorrect for Rails/FindByOrAssignmentMemoization when using endless method definition.

Fixes #1530.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This PR fixes an incorrect autocorrect for `Rails/FindByOrAssignmentMemoization`
when using endless method definition.

Fixes rubocop#1530.
@koic koic merged commit 17371a8 into rubocop:master Sep 12, 2025
15 checks passed
@koic koic deleted the fix_an_incorrect_autocorrect_for_rails_find_by_or_assignment_memoization branch September 12, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rails/FindByOrAssignmentMemoization autocorrect behavior leads to unintuitive test failures

1 participant