Skip to content

Cop idea: Negative #valid? method #1015

Closed
@ydakuka

Description

@ydakuka

Actual behavior

I have the code:

class AdvertsController < ApplicationController
  # PATCH /adverts/:id
  def update
    render :edit unless @form.valid?
  end
end

I run rubocop:

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop spec/forms/advert_form_spec.rb
Inspecting 1 file
.

1 file inspected, no offenses detected

Expected behavior

I expected to receive the following code:

class AdvertsController < ApplicationController
  # PATCH /adverts/:id
  def update
    render :edit if @form.invalid?
  end
end

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions