Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubicon Adapter with SRA-GET support (HB-2145) #13

Closed
wants to merge 65 commits into from
Closed

Update Rubicon Adapter with SRA-GET support (HB-2145) #13

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
2d26659
Modified code for easier code merge
Feb 13, 2018
826261a
Reverted digitrust function in-lining
Feb 13, 2018
0dc32d7
Added missing function jsdoc
Feb 13, 2018
d9c70e6
Added cpm sort to fix broken unit tests
Feb 14, 2018
3797107
Fixed linting errors
Feb 14, 2018
4ffa40d
Bug fix to map converted bids before combining, added empty/undefined…
Feb 14, 2018
85ffec7
Added referrer and page_url changes and spec sinon sandbox.stub updat…
Feb 15, 2018
df3d331
Added referrer and page_url changes
Feb 15, 2018
da85489
Fixed broken unit tests
Feb 15, 2018
2752d7b
Added request parameter tg_fl.eid for non-video requests
idettman Feb 16, 2018
0cc3a43
Removed spaces to correct linting error
Feb 16, 2018
088c7ea
Replaced calls to JSON.stringify and parse with the 'clone' helper fu…
Feb 16, 2018
06ce341
Updated unit tests for new sra get param 'tg_fl.eid'
Feb 16, 2018
36aad9f
Updated with requested changes from pull request
Feb 16, 2018
151f268
Extracted code for page_url to a function for reuse
Feb 16, 2018
653b19e
Added unit test for sra request limited to 10 slots
Feb 16, 2018
a2cf89c
Updated comment
Feb 16, 2018
8fb38e0
Added warning for bids dropped from SRA get request
Feb 16, 2018
b9e747b
Changed log execution line ordering in max bids limit block
Feb 16, 2018
25dd212
Updated until test description
Feb 16, 2018
d914977
Added unit test for expectedQuery function
Feb 16, 2018
595fa90
Fixed unit test for createSlotParams
Feb 16, 2018
b54dab6
Add additional unit tests
Feb 22, 2018
f8a917c
Updated unit test for max of 10 slots sent per request
Feb 22, 2018
ccd4bd5
Updated with changed from media types update branch, added error if r…
Feb 22, 2018
ddf16cc
Fix for video bid validation backwards compatibility
Feb 23, 2018
5b0c748
Merged code from updated media types branch
Feb 23, 2018
0f0cc8b
Temp commit before refactoring extracting inline code to functions
Feb 23, 2018
f5230f3
Added additional unit tests for interpret response
Feb 23, 2018
0e889e1
Fix for validate bids
Feb 23, 2018
3518d2c
Modified code for easier code merge
Feb 13, 2018
4878781
Reverted digitrust function in-lining
Feb 13, 2018
12d9641
Added missing function jsdoc
Feb 13, 2018
3b96f9c
Added cpm sort to fix broken unit tests
Feb 14, 2018
7452e3c
Fixed linting errors
Feb 14, 2018
8a40e93
Bug fix to map converted bids before combining, added empty/undefined…
Feb 14, 2018
cbe4667
Added referrer and page_url changes and spec sinon sandbox.stub updat…
Feb 15, 2018
2a00f36
Added referrer and page_url changes
Feb 15, 2018
61d3733
Fixed broken unit tests
Feb 15, 2018
c3f2bf5
Added request parameter tg_fl.eid for non-video requests
idettman Feb 16, 2018
ca78319
Removed spaces to correct linting error
Feb 16, 2018
c75d5e5
Replaced calls to JSON.stringify and parse with the 'clone' helper fu…
Feb 16, 2018
72c1b9d
Updated unit tests for new sra get param 'tg_fl.eid'
Feb 16, 2018
40dd0ac
Updated with requested changes from pull request
Feb 16, 2018
d83635a
Extracted code for page_url to a function for reuse
Feb 16, 2018
6129eee
Added unit test for sra request limited to 10 slots
Feb 16, 2018
148aec3
Updated comment
Feb 16, 2018
3348ac0
Added warning for bids dropped from SRA get request
Feb 16, 2018
182e17b
Changed log execution line ordering in max bids limit block
Feb 16, 2018
a995782
Updated until test description
Feb 16, 2018
6aaef71
Added unit test for expectedQuery function
Feb 16, 2018
14be5bb
Fixed unit test for createSlotParams
Feb 16, 2018
e9f844a
Add additional unit tests
Feb 22, 2018
ffb5854
Updated unit test for max of 10 slots sent per request
Feb 22, 2018
101d5ce
Updated with changed from media types update branch, added error if r…
Feb 22, 2018
e4971b2
Fix for video bid validation backwards compatibility
Feb 23, 2018
a5a7044
Merged code from updated media types branch
Feb 23, 2018
9025492
Temp commit before refactoring extracting inline code to functions
Feb 23, 2018
0123c7f
Added additional unit tests for interpret response
Feb 23, 2018
28fa3d2
Fix for validate bids
Feb 23, 2018
7637845
Rebased/merged with master
Feb 24, 2018
419bcb3
Merge branch 'rubicon-adapter-sra-support' of https://github.com/rubi…
Feb 27, 2018
215eb29
Removed code/tests to validate matching order for ad and bidRequest a…
Feb 27, 2018
5f862b5
Removed validation for root response obj status, it was getting an er…
Feb 27, 2018
fcf4d4f
Updated interpretResponse validation for response obj to test for typ…
Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading