Tags backend #1
Closed
Tags backend #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenvp8510
force-pushed
the
tags_backend
branch
from
56d89bc
to
340ae76
Compare
…rafana#2882) * upgrade Azure SDK from azure-storage-blob-go to azure-sdk-for-go * update authentication block * remove comment * update CHANGELOG * remove comments * go mod tidy in cmd/tempo-serverless/lambda * go mod tidy in cmd/tempo-serverless/cloud-run * change instead of enhancement * retry once instead of zero times * add comment * defensive pointer checks * pass ctx instead of using context.Background() * defensive pointer checks * remove delete() method * defensive pointer checks * fix linter * streamline authentication switch * fix linter * pointer clients
rubenvp8510
force-pushed
the
tags_backend
branch
from
7a1e1c9
to
12be403
Compare
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
* Add workflow to update `make docs` procedure Signed-off-by: Jack Baldry <jack.baldry@grafana.com> * Update `make docs` procedure Signed-off-by: Jack Baldry <jack.baldry@grafana.com> --------- Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
* testing * undo logs * add target_info_excluded_dimensions to userconfig * added test & changelog * fix test
* Use errorlint to check for plain error comparisons and type assertions * Explicitly load golangci-lint config file * Fix linter warnings about plain error comparison * Fix linter warnings about plain error type assertions * Implement tooManySpansError.Error() with pointer receiver * Implement traceTooLargeError.Error() with pointer receiver * Implement unsupportedError.Error() with pointer receiver * Implement ParseError.Error() with pointer receiver * Improve comment for errorlint in .golangci.yml * Implement validationError.Error() with pointer receiver * Check for ParseError using errors.As() * Remove custom multi error implementation * More readable condition for errors.Is(err, context.Canceled) * Implement validationError.Unwrap()
* Update Pushing spans HTTP doc * Update docs/sources/tempo/api_docs/pushing-spans-with-http.md * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Mario <mariorvinas@gmail.com> --------- Co-authored-by: Mario <mariorvinas@gmail.com>
* testing * undo logs * add target_info_excluded_dimensions to userconfig * make trace-summary more efficient * rename * nil pointer * reduce memory usage and add percentage option Signed-off-by: Joe Elliott <number101010@gmail.com> * reduce root span mem use. don't check compacted blocks Signed-off-by: Joe Elliott <number101010@gmail.com> * print out not found Signed-off-by: Joe Elliott <number101010@gmail.com> * lint * add comment --------- Signed-off-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Joe Elliott <number101010@gmail.com>
* Begin move Azure SDK to v2 * New packages for v1 and v2 Azure backends * Fix azure config reference * Update vendor * Update serverless go.mod and config reference * Lint azure/v1/v1.go * Lint azure test * Include docs for new config * Update changelog
rubenvp8510
force-pushed
the
tags_backend
branch
from
12be403
to
3ccbf60
Compare
* First draft of fix for some cases where empty spansets don't work right * Refine the fix * Fix tests * comments * changelog * StartTime is better and tweak spanset operation so it stays fast * add benchmarks * oops forgot to fix test
…ed overrides for tenant (grafana#2915) * User-configurable overrides: add scope query parameter to return merged overrides for tenant * Update CHANGELOG.md * Linting
* enforce max bytes on trace by id path Signed-off-by: Joe Elliott <number101010@gmail.com> * revert changes to status handling Signed-off-by: Joe Elliott <number101010@gmail.com> * added e2e test Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * moved error checking to the combiner Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * return 400 from the querier for most cases Signed-off-by: Joe Elliott <number101010@gmail.com> * remove load Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
…overrides api (grafana#2928) * Add spanmetrics, servicegraph histogram buckets to user-configurable overrides api * Linting * Fix typo --------- Co-authored-by: Koenraad Verheyden <koenraad.verheyden@grafana.com>
…rafana#2955) * Standardise error formatting using standard library errors package * Standardise improve non-idiomatic error messages * Make github.com/pkg/errors an indirect dependency Co-authored-by: A. Stoewer <adrian@stoewer.me>
Signed-off-by: Heds Simons <hedley.simons@grafana.com> Co-authored-by: A. Stoewer <adrian@stoewer.me>
* Add subpages for query editor doc * Update PR with Jack's changes
* Remove TNS app from doc * Update docs/sources/tempo/setup/tanka.md
* Update `make docs` procedure * Trigger CI --------- Co-authored-by: grafanabot <bot@grafana.com> Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
…grafana#2961) * Remove intermediate spanset layer. Various other cleanups * Use static intrinsic attributes in traceql package * Apply updates to vParquet2 * Switch back to faster type checks * Replace other key checks with type checks * Apply same updates to vParquet2 * comment
… not forks (grafana#2982) Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
* Upgrade dskit dependency to latest main * Revert upgrades to otel dependencies * rm kuberesolver/v5/README.md * Add kuberesolver/v5/README.md * no touch crlf?
* Fix spurious error message in distributor * Local blocks processor honors tenant DedicatedColumns overrides
* Fix error return in generator pushes * Guard fmt.Errorf calls with err != nil In grafana#2955 tempo replaced usage of github.com/pkg/errors with errors package from the standard library. In that process errors.Wrap calls were replaced with fmt.Errorf, and there a difference in the way both work with `nil` error. e.g: `errors.Wrap(nil, "test")` is `<nil>`, but `fmt.Errorf("test", nil)` is `test%!(EXTRA <nil>)` so we need to guard fmt.Errorf calls to avoid returning errors when `err` is `nil`. --------- Co-authored-by: Suraj Nath <9503187+electron0zero@users.noreply.github.com>
* metrics-generator disable x-scope-orgid header append * Update CHANGELOG.md * Updated as per review comments 1. Changed removeOrgIdHeader to addOrgIdHeader 2. addOrgIdHeader default value will be true * Update CHANGELOG.md Co-authored-by: Joe Elliott <joe.elliott@grafana.com> * changed addorgidheader config from pointer to normal variable * Moved addOrgIDHeader check --------- Co-authored-by: Joe Elliott <joe.elliott@grafana.com>
* Update Alpine image to 3.19 * Update changelog
* Update Set up test app to use agent flow * Apply suggestions from code review * Correct a distributor reference to query frontend. Also makes a creation step for `values.yaml` generic. Signed-off-by: Heds Simons <hedley.simons@grafana.com> * Apply suggestions from code review * Apply suggestions from code review --------- Signed-off-by: Heds Simons <hedley.simons@grafana.com> Co-authored-by: Heds Simons <hedley.simons@grafana.com>
* FIX-2605: Make span.resource.xyz attributes work * Update CHANGELOG.md Co-authored-by: Joe Elliott <joe.elliott@grafana.com> --------- Co-authored-by: Joe Elliott <joe.elliott@grafana.com>
* Bring back localblocks filtering with config option * Update changelog and docs * FilterServerSpans true by default
* first pass - working Signed-off-by: Joe Elliott <number101010@gmail.com> * refactor Signed-off-by: Joe Elliott <number101010@gmail.com> * working? Signed-off-by: Joe Elliott <number101010@gmail.com> * vendor Signed-off-by: Joe Elliott <number101010@gmail.com> * integration test Signed-off-by: Joe Elliott <number101010@gmail.com> * updated go.mod to latest Signed-off-by: Joe Elliott <number101010@gmail.com> * cleanup Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * update servless mods Signed-off-by: Joe Elliott <number101010@gmail.com> * satisfy interface updates Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
* Keep track of trace sizes for the lifetime of the headblock, add metrics * lint * Comment * Fix invalid assumption that all batches have the same trace id. Undo variable name change, review comments * changelog
* removed websocket support Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
* Add /status/overrides/{tenant} endpoint
* Add /status/overrides as alias of /status/runtime_config
* Add tests for getRuntimeOverridesFor
* make fmt
* Variety of metrics/iter improvements. Add benchmark * Undo iterator clone cache because benefits aren't as clear * lint * add/update tests
* Prepare best practices doc for sharing * Update docs/sources/tempo/operations/best-practices.md Co-authored-by: Jack Baldry <jack.baldry@grafana.com> * Update docs/sources/tempo/operations/best-practices.md * Update docs/sources/tempo/shared/best-practices-traces.md * Update docs/sources/tempo/shared/best-practices-traces.md * Apply suggestions from code review * Update docs/sources/tempo/shared/index.md --------- Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
Added the text from this PR, since the original PR was gone stale.
* Fix spanmetrics filtering when multiple policies are applied * Update changelog * Include additional test coverage and adjust * Update docs * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update changelog to note breaking change * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Reword docs * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * Update docs/sources/tempo/metrics-generator/span_metrics.md Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> --------- Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
* Fix typo in service graph metric name Seems like we updated the metric names from tempo_ to traces_ in the section below, but not in this specific example. * change metric name from tempo_ to traces_ fixed the same typo in one other spot
Co-authored-by: grafanabot <bot@grafana.com> Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
* Add blog link to release notes * Update tail-based sampling doc * Fix links for linting * Apply suggestions from code review Co-authored-by: Heds Simons <hedss@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Heds Simons <hedss@users.noreply.github.com> * Apply suggestions from code review * Update tail-based-sampling.md Fixed comment formatting --------- Co-authored-by: Heds Simons <hedss@users.noreply.github.com>
Add multi-tenant query support in streaming search endpoints. follow up on grafana#3087
* Add videos to docs * Add videos to Tempo docs * Apply suggestions from code review * Apply suggestions from code review * Update docs/sources/tempo/getting-started/tempo-in-grafana.md
… that conflict with runtime overrides (grafana#3180) * User-configurable overrides: add optional check to block API requests that conflict with runtime overrides * Simplify interface, omit concept of a level * Drop gofakeit.Fakeable interface implementation * Add UserConfigurableOverridesAPIConfig.RegisterFlagsAndApplyDefaults * Fix test, return err when parameter can not be parsed * Addressing review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]