-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 'new' command #23
Comments
One thing I didn't want to enforce is a naming convention for migrations (the prefix). You can use the epoch, some kind of formatted time stamp or a sequence number; you can separate it using dashes or underscores: all these options are perfectly fine and valid, it's just a choice you make for your project. I'd love to have a If we can figure that out: yes please! |
OK so how about we have a way of specifying the format in the config or use the default? Options could be
Also I would like to append the sql-migrate new udf-ParseDate alter results in If action is |
How would that work?
Can we be smart about it and detect the used style from existing migration files? |
As an outline, it would:
We could do, so look at the first & last file and use regex to work out the format. Personally I'd rather use the config file rather than trying to be smart (KISS principle). At the end of the day, this would only affect the |
I guess we have different opinions on KISS then :-). Any piece of configuration we can avoid is a net win, but if the alternative is something that barely works, sure. |
Is it bad to use a default prefix if you allow them to change the prefix-pattern in the config? I personally have always used the YYYY-MM-DD-HH-II-SS pattern but a sequence number or epoch would work just as good. Personally I would not think it's bad to choose a default and then just let the config decide. Do you feel that you are enforcing them when choosing a default that can be changed in the config? |
I'd find this quite useful. I'd also make sense because incrementing the prefix by hand doesn't work in big teams where people create migrations simultanously and creating a timestamp by hand just feels weird. Many modern migration cli tools offer a |
Thanks to the wonderful work of @yageek, there's now a It's not configurable nor smart, but we had to start somewhere. If someone is willing to make this format configurable and/or smart, feel free to join in! |
Implement the `new` command as proposed within the issue rubenv#23.
Add new command as specified in rubenv#23
Just wondered if others would find this useful...
I'd like to see a
new
command so when using the command line I can doand it create a templated file in the
./migration
folder (or what ever this is set in the config) named<current epoch>-<name>.sql
, eg:1443610373-udf-ParseDate.sql
The templating would have the
-- +migrate Up
and-- +migrate Down
defined.An enhancement to this would be to take the
name
and scan for the last migration matching the name and populate themigrate Down
section of the template from the lastmigrate Up
script.Comments appreciated, if people like this I'll look at PR.
The text was updated successfully, but these errors were encountered: