[mysql-cdc] Add handler for catching async exceptions in snapshot rea…

…ding executor This closes apache#2016.
ruanhang1993 · Jun 7, 2023 · 29713db · 29713db
1 parent 70db0d2
commit 29713db
Showing 1 changed file with 22 additions and 11 deletions.
diff --git a/...src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/SnapshotSplitReader.java b/...src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/SnapshotSplitReader.java
@@ -95,7 +95,11 @@ public class SnapshotSplitReader implements DebeziumReader<SourceRecords, MySqlS
     public SnapshotSplitReader(StatefulTaskContext statefulTaskContext, int subtaskId) {
         this.statefulTaskContext = statefulTaskContext;
         ThreadFactory threadFactory =
-                new ThreadFactoryBuilder().setNameFormat("snapshot-reader-" + subtaskId).build();
+                new ThreadFactoryBuilder()
+                        .setNameFormat("debezium-reader-" + subtaskId)
+                        .setUncaughtExceptionHandler(
+                                (thread, throwable) -> setReadException(throwable))
+                        .build();
         this.executorService = Executors.newSingleThreadExecutor(threadFactory);
         this.currentTaskRunning = false;
         this.hasNextElement = new AtomicBoolean(false);
@@ -120,7 +124,7 @@ public void submitSplit(MySqlSplit mySqlSplit) {
                         statefulTaskContext.getSnapshotReceiver(),
                         StatefulTaskContext.getClock(),
                         currentSnapshotSplit);
-        executorService.submit(
+        executorService.execute(
                 () -> {
                     try {
                         currentTaskRunning = true;
@@ -160,20 +164,14 @@ public void submitSplit(MySqlSplit mySqlSplit) {
                                     new SnapshotBinlogSplitChangeEventSourceContextImpl(),
                                     mySqlOffsetContext);
                         } else {
-                            readException =
+                            setReadException(
                                     new IllegalStateException(
                                             String.format(
                                                     "Read snapshot for mysql split %s fail",
-                                                    currentSnapshotSplit));
+                                                    currentSnapshotSplit)));
                         }
                     } catch (Exception e) {
-                        currentTaskRunning = false;
-                        LOG.error(
-                                String.format(
-                                        "Execute snapshot read task for mysql split %s fail",
-                                        currentSnapshotSplit),
-                                e);
-                        readException = e;
+                        setReadException(e);
                     }
                 });
     }
@@ -335,6 +333,19 @@ private void assertLowWatermark(SourceRecord lowWatermark) {
                         lowWatermark));
     }
 
+    private void setReadException(Throwable throwable) {
+        currentTaskRunning = false;
+        LOG.error(
+                String.format(
+                        "Execute snapshot read task for mysql split %s fail", currentSnapshotSplit),
+                throwable);
+        if (readException == null) {
+            readException = throwable;
+        } else {
+            readException.addSuppressed(throwable);
+        }
+    }
+
     @Override
     public void close() {
         try {