Multi port updated #318
Merged
Multi port updated #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olbjo
force-pushed
the
multi_port_updated
branch
from
cb4e194 to
0b2fcea
Compare
pyhys
reviewed
Jan 28, 2021
pyhys
approved these changes
Feb 1, 2021
olbjo
force-pushed
the
multi_port_updated
branch
2 times, most recently
from
ef5da6b to
cb1f00a
Compare
- Handle lldp name of station mode - Default name of station mode set to standard - In lldp replace zero-len station name with mac - Update tests
olbjo
force-pushed
the
multi_port_updated
branch
from
cb1f00a to
3b09d41
Compare
hefloryd
reviewed
Feb 4, 2021
| @@ -96,11 +96,16 @@ Run ``ifconfig`` to check that the bridge is up and its network interfaces are a | |||
| Configuration of p-net stack and sample application | |||
| --------------------------------------------------------- | |||
| To run p-net and the sample application with multiple ports a couple | |||
| of things need to be done: | |||
| of things need to be done. Note that the settings described in the | |||
There was a problem hiding this comment.
If we explain ccmake then you should maybe also mention that options can be set on the command line when configuring (-DPNET_MAX_PORTS=2), which is probably how you would set it in a build script or similar.
| @@ -56,15 +56,25 @@ | |||
| </InterfaceSubmoduleItem> | |||
| <PortSubmoduleItem ID="IDS_P1" SubmoduleIdentNumber="0x00008001" SubslotNumber="32769" TextId="IDT_NAME_PS1" MaxPortRxDelay="350" MaxPortTxDelay="160"> | |||
| <MAUTypeList> | |||
| <!-- | |||
| MAUTypeItems shall match the actual network interfaces of the device. | |||
| Current list is works for Raspberry Pi, Linksys usb/ethernet dongle and xmc sample targets | |||
| @@ -101,13 +101,13 @@ const pnet_port_cfg_t * pf_port_get_config (pnet_t * net, int loc_port_num) | |||
| uint16_t pf_port_loc_port_num_to_dap_subslot (int loc_port_num) | |||
There was a problem hiding this comment.
These functions should have tests (or regression tests for the problem being fixed).
Needed to report correct port status.
olbjo
force-pushed
the
multi_port_updated
branch
from
3b09d41 to
ee307d4
Compare
olbjo
force-pushed
the
multi_port_updated
branch
from
ee307d4 to
c7915fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc updates to pass Automated RT test suite on Raspberry Pi with an usb/ethernet dongle as a second port.
Includes / rebased on #319