fix: hold mutex when signaling cond var #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mutex is not held when signalling the condition variable, a thread woken up by the mutex unlock, may have lower priority than the thread waiting on the condition leading to priority inversion. We also don't need to wake up waiters when we clear events, since this will never trigger return from the wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mutex is not held when signalling the condition variable, a thread woken up by the mutex unlock,
may have lower priority than the thread waiting
on the condition leading to priority inversion.
We also don't need to wake up waiters when we
clear events, since this will never trigger
return from the wait.