fix: resolve clippy warnings in container, git, and init modules - #583
fix: resolve clippy warnings in container, git, and init modules#583bz00qa wants to merge 1 commit into
Conversation
Apply clippy suggestions carved out from feature PRs rtk-ai#551 and rtk-ai#552: - container.rs: .last() → .next_back() (2 instances) - git.rs: .map_or(false, ...) → .is_some_and(...) (2 instances) - git.rs: .last() → .next_back() (1 instance) - init.rs: unnecessary format!() → .to_string() (1 instance) - init.rs: unnecessary & on &str parameters (2 instances) Signed-off-by: bZ00qa <167500396+bz00qa@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
|
Closing this PR for inactivity — the CLA was never signed and there's been no activity since March. This isn't a judgment on the change itself. If you'd still like to land it, just sign the CLA (https://cla-assistant.io/rtk-ai/rtk) and ping a maintainer to reopen — happy to pick it back up. Thanks for the contribution! |
Summary
.last()→.next_back()(2 instances).map_or(false, ...)→.is_some_and(...)(2 instances),.last()→.next_back()(1 instance)format!()→.to_string()(1 instance), unnecessary&on&strparameters (2 instances)Test plan
cargo clippy --all-targetspassescargo testpasses (937 passed, 2 pre-existing failures unrelated to these changes)🤖 Generated with Claude Code