feat: add oh-my-pi (omp) as a supported agent#2166
Open
oldschoola wants to merge 1 commit into
Open
Conversation
Adds a parallel extension-based integration for oh-my-pi
(@oh-my-pi/pi-coding-agent, binary 'omp'), alongside the
existing @earendil-works/pi-coding-agent ('pi') integration.
- New hooks/omp/rtk.ts TypeScript extension delegating to
'rtk rewrite' via the omp ExtensionAPI (tool_call event,
isToolCallEventType('bash', event), pi.exec, fail-open)
- AgentTarget::OhMyPi clap variant: --agent omp (alias oh-my-pi)
- Install paths: ~/.omp/agent/extensions/rtk.ts (global,
overridable via PI_CODING_AGENT_DIR) or .omp/extensions/rtk.ts
(project-local)
- run_omp_mode / uninstall_omp wired through run_cli and
uninstall_init_dispatch alongside Pi and Hermes
- 12 mirrored unit tests covering install / uninstall / dry-run
for both global and local scope, plus 3 CLI parse tests
- README + hooks/README list oh-my-pi as a 14th/10th agent
Existing @earendil-works pi integration left fully intact.
|
oh-my-pi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds oh-my-pi (
@oh-my-pi/pi-coding-agent, binaryomp) as a new agent integration, parallel to the existingpi(@earendil-works/pi-coding-agent) hook. They are different projects that happen to share a name and anExtensionAPIshape; the existingpiintegration is left fully intact.hooks/omp/rtk.ts— delegates tortk rewriteon thetool_callevent via theompExtensionAPI, fail-open, version-guardedrtk >= 0.40.0.AgentTarget::OhMyPiclap variant:rtk init --agent omp(alias--agent oh-my-pi). Install paths:~/.omp/agent/extensions/rtk.tsglobal (honors the samePI_CODING_AGENT_DIRenv thatoh-my-piitself reads) or.omp/extensions/rtk.tsproject-local.run_omp_mode/uninstall_ompwired throughrun_clianduninstall_init_dispatchalongsidePiandHermes; doc updates in top-levelREADME.mdandhooks/README.md.Test plan
cargo buildcleancargo test --bin rtk— 2003 passed, 0 failed (1997 baseline + 12 new mirrored install/uninstall/dry-run tests for both global and local scope + 3 new CLI parse tests for--agent omp, theoh-my-pialias, and the uninstall form)rtk init --agent omp --dry-runandrtk init --agent oh-my-pi --dry-runboth emit the expected "would create.omp/extensions/rtk.ts" plan;rtk init --helplists the new variantcargo fmt --all && cargo clippy --all-targets— not run on this Windows workstation; happy to run if CI flags anythingNotes
pi(earendil) integration is completely untouched — no shared code paths were modified, only new symbols added.ompreuses the existingPI_CODING_AGENT_DIRenv var because theoh-my-piruntime itself reads that same variable (different default base:.omp/agentvs.pi/agent). Documented inhooks/omp/README.md.hooks/omp/rtk.tsmirrorshooks/pi/rtk.tsline-for-line aside from the import source and the minimum-version constant — keeps future cross-maintenance trivial.