Route rg --files to find#1903
Open
LK4D4 wants to merge 1 commit into
Open
Conversation
79d6e49 to
5e6e101
Compare
d3c1381 to
02c39ff
Compare
02c39ff to
1abac94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rg --fileshook invocations to RTK find syntax with explicit--max 50and--file-type f.Why
rg --filesis a common agent command for listing repository files. Right now,rtk rewrite rg --filesreturnsrtk grep --fileswhich doesn't work and only wastes execution.I opted out for RTK syntax instead of find syntax to give hints to the agent about
--maxwhich works really bad with native syntax parser. We also should probably updatertk find --helpto explain this stuff more.Fix #2060