This repository has been archived by the owner on Jul 24, 2021. It is now read-only.
Allow to configure severity threshold. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sundus-y
commented
Oct 27, 2018
sundus-y
commented
- Add severity-threshold option to check minimum severity to check.
- Apply a red color based on threshold only for text STDOUT.
- Fix for Issue Allow to configure severity threshold #6
* Add severity-threshold option to check minimum severity to check. * Apply a red color based on threshold only for text STDOUT.
* Fixing Codacy faliures.
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
Repository owner
deleted a comment
Oct 27, 2018
* Fixing Rubocop Failures.
rtfpessoa
suggested changes
Oct 28, 2018
|
Overall looks nice. Please take a look at my suggestions. |
* Updated the yavdb gem to make use of the SEVERITIES constant * definition. * Merged the formatter and style code for the text formatter. * Clean up code after code review.
|
@rtfpessoa I have made all the suggestions that you had. I tried running the rspec on master and it falling on |
|
@sundus-y, just fixed it in master. Please rebase. |
* Remove unused variable definition.
* Add severity-threshold option to check minimum severity to check. * Apply a red color based on threshold only for text STDOUT.
* Fixing Codacy faliures.
* Fixing Rubocop Failures.
* Updated the yavdb gem to make use of the SEVERITIES constant * definition. * Merged the formatter and style code for the text formatter. * Clean up code after code review.
* Remove unused variable definition.
Repository owner
deleted a comment
Oct 28, 2018
* Fix Ruboco empty white space.
Repository owner
deleted a comment
Oct 28, 2018
|
@rtfpessoa Just rebased and looks like everything is looking good. |
rtfpessoa
approved these changes
Oct 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.