Merge pull request #195 from mbjurman/ImmutableError-should-be-an-error

Changed ImmutableError to be an instance of Error
rtfeldman · Feb 12, 2017 · 5068f09 · 5068f09
2 parents c85562d + b6b3843
commit 5068f09
Show file tree

Hide file tree

Showing 8 changed files with 59 additions and 16 deletions.
diff --git a/seamless-immutable.development.js b/seamless-immutable.development.js
@@ -99,13 +99,12 @@ function immutableInit(config) {
   ]);
 
   function ImmutableError(message) {
-    var err       = new Error(message);
-    // TODO: Consider `Object.setPrototypeOf(err, ImmutableError);`
-    err.__proto__ = ImmutableError;
-
-    return err;
+    this.name = 'MyError';
+    this.message = message;
+    this.stack = (new Error()).stack;
   }
-  ImmutableError.prototype = Error.prototype;
+  ImmutableError.prototype = new Error;
+  ImmutableError.prototype.constructor = Error;
 
   function makeImmutable(obj, bannedMethods) {
     // Tag it so we can quickly tell it's immutable later.

diff --git a/seamless-immutable.development.min.js b/seamless-immutable.development.min.js