Skip to content

Comments

Be explicit on logout sending a null value#87

Open
nikoskalogridis wants to merge 1 commit intortfeldman:masterfrom
nikoskalogridis:patch-1
Open

Be explicit on logout sending a null value#87
nikoskalogridis wants to merge 1 commit intortfeldman:masterfrom
nikoskalogridis:patch-1

Conversation

@nikoskalogridis
Copy link

@nikoskalogridis nikoskalogridis commented Nov 19, 2019

Instead of sending a Maybe value we send explicitly a Encode.null value in the logout function.

The main reason I am proposing this is that SimulatedEffect.Ports.send takes always a Decode.Value so its easier to test this.

It's also not preferred as said in the official elm docs

Sending Json.Decode.Value through ports is recommended, but not the only way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant