Skip to content

Add support for crios (chrome on iOS) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for crios (chrome on iOS) #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15afd7e
Add support for crios (chrome on iOS)
aoimasu Dec 19, 2023
3d5c43e
4.4.2
aoimasu Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 38 additions & 19 deletions capabilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,54 @@
'use strict';
"use strict"

var browser = require('detect-browser').detect();
var compareVersions = require('compare-versions')
const browser = require("detect-browser").detect()
const compareVersions = require("compare-versions")

var capabilities = module.exports = {
moz: typeof navigator != 'undefined' && !!navigator.mozGetUserMedia,
browser: browser.name,
browserVersion: browser.version
};
const capabilities = (module.exports = {
moz: typeof navigator != "undefined" && !!navigator.mozGetUserMedia,
browser: browser.name,
browserVersion: browser.version,
})

const getConstraintsType = (condition: boolean) =>
condition ? "standard" : "legacy"

// Mozilla constraings handling
if (capabilities.moz) {
capabilities.constraintsType = (compareVersions(browser.version, '38.0.0') >= 0 ? 'standard' : 'legacy');
capabilities.constraintsType = getConstraintsType(
compareVersions(browser.version, "38.0.0") >= 0
)
}
// Chrome constraints handling
else if (browser.name === 'chrome') {
capabilities.constraintsType = (compareVersions(browser.version, '53.0.0') >= 0 ? 'standard' : 'legacy');
else if (browser.name === "chrome") {
capabilities.constraintsType = getConstraintsType(
compareVersions(browser.version, "53.0.0") >= 0
)
}
// Chrome on iOS constraints handling
else if (browser.name === "crios") {
capabilities.constraintsType = getConstraintsType(
compareVersions(browser.version, "56.0.0") >= 0
)
}
// Safari constraints handling
else if (browser.name === 'safari') {
capabilities.constraintsType = (compareVersions(browser.version, '12.0.0') >= 0 ? 'standard' : 'legacy');
else if (browser.name === "safari") {
capabilities.constraintsType = getConstraintsType(
compareVersions(browser.version, "12.0.0") >= 0
)
}
// Edge constraints handling
else if ((/^edge.*$/).test(browser.name)) {
capabilities.constraintsType = (compareVersions(browser.version, '79.0.0') >= 0 ? 'standard' : 'legacy');
else if (/^edge.*$/.test(browser.name)) {
capabilities.constraintsType = getConstraintsType(
compareVersions(browser.version, "79.0.0") >= 0
)
}
// iOS Safari constraints handling
else if (browser.name === 'ios') {
capabilities.constraintsType = (compareVersions(browser.version, '11.0.0') >= 0 ? 'standard' : 'legacy');
else if (browser.name === "ios") {
capabilities.constraintsType = getConstraintsType(
compareVersions(browser.version, "11.0.0") >= 0
)
}
// Default constraints handling
else {
capabilities.constraintsType = 'legacy';
}
capabilities.constraintsType = "legacy"
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rtc-captureconfig",
"version": "4.4.1",
"version": "4.4.2",
"description": "Simple string definition -> WebRTC constraints",
"main": "index.js",
"scripts": {
Expand Down