Skip to content

Add support for AMP Stories #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2019
Merged

Add support for AMP Stories #98

merged 5 commits into from
Sep 19, 2019

Conversation

thrijith
Copy link
Contributor

@thrijith thrijith commented Sep 6, 2019

  • Extend support for video mime type in AMP Story Background Media and Video Block

Depends on ampproject/amp-wp#3171

@thrijith thrijith marked this pull request as ready for review September 10, 2019 07:04
@thrijith thrijith requested a review from dharmin September 10, 2019 07:40
Copy link
Contributor

@dharmin dharmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some minor changes.

Copy link
Contributor

@dharmin dharmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pradeep910
Copy link

@dharmin @pooja-muchandikar is this well tested?

@thrijith thrijith requested a review from dharmin September 16, 2019 09:17
Copy link
Contributor

@dharmin dharmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thrijith thrijith merged commit c7b5c6f into rtCamp:develop Sep 19, 2019
@thrijith thrijith changed the title Extend Video Mime type support for AMP Story Add support for AMP Stories Sep 19, 2019
@thrijith thrijith deleted the add/amp-story-video-support branch September 19, 2019 15:59
This was referenced Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants