fix error on media comment while activity stream is disabled #1028 #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrapatel
approved these changes
Jan 1, 2018
BhargavBhandari90
suggested changes
Jan 3, 2018
app/admin/RTMediaFormHandler.php
Outdated
| if ( ! bp_is_active( 'activity' ) ) { | ||
| ?> | ||
| <script> | ||
| jQuery( '#rtmedia-bp-enable-activity' ).prop( "disabled", true ).next().css( 'background', 'grey' ); |
There was a problem hiding this comment.
Use hexcode instead of grey.
app/admin/RTMediaFormHandler.php
Outdated
| jQuery( '#rtmedia-bp-enable-activity' ).prop( "disabled", true ).next().css( 'background-color', '#808080' ); | ||
| jQuery( '#rtmedia-activity-feed-limit' ).prop( "disabled", true ); | ||
| jQuery( '#rtmedia-enable-like-activity' ).prop( "disabled", true ).next().css( 'background-color', '#808080' ); | ||
| jQuery( '#rtmedia-enable-comment-activity' ).prop( "disabled", true ).next().css( 'background-color', '#808080' ); |
There was a problem hiding this comment.
You can make this one lined
jQuery( '#rtmedia-bp-enable-activity, #rtmedia-enable-like-activity, #rtmedia-enable-comment-activity' ).prop( "disabled", true ).next().css( 'background-color', '#808080' );
Sorry for not pointing out in previous review
BhargavBhandari90
approved these changes
Jan 4, 2018
chandrapatel
approved these changes
Jan 4, 2018
if BuddyPress User Groups is disabled
app/admin/RTMediaFormHandler.php
Outdated
| $render_options['rtmedia-activity-feed-limit']['args']['desc'] = | ||
| $render_options['rtmedia-enable-like-activity']['args']['desc'] = | ||
| $render_options['rtmedia-enable-comment-activity']['args']['desc'] = | ||
| 'Please Enable BuddyPress Activity Streams to update option'; |
There was a problem hiding this comment.
Make this translatable
app/admin/RTMediaFormHandler.php
Outdated
| $render_options = apply_filters( 'rtmedia_album_control_setting', $render_options, $rtmedia->options ); | ||
| if ( ! bp_is_active( 'groups' ) ) { | ||
| $render_options['rtmedia-enable-on-group']['args']['desc'] = | ||
| 'Please Enable BuddyPress User Groups to update option'; |
There was a problem hiding this comment.
Make this translatable
juhi123
added a commit
to juhi123/rtMedia
that referenced
this pull request
Jan 10, 2018
juhi123
added a commit
to juhi123/rtMedia
that referenced
this pull request
Jan 10, 2018
This reverts commit 31e116b.
juhi123
added a commit
to juhi123/rtMedia
that referenced
this pull request
Jan 10, 2018
juhi123
added a commit
to juhi123/rtMedia
that referenced
this pull request
Jan 10, 2018
thrijith
added a commit
that referenced
this pull request
Mar 15, 2018
Fix Travis Build Fail for PR #1030
thrijith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fatal error on media comment while activity stream is disabled #1028
when activity stream is disabled
bp_activity_addandbp_activity_deletewill not work so added condition to check if the function is available to solve the fatal error.