Skip to content

Fix: user request issue#14

Merged
up1512001 merged 2 commits intodevelopfrom
fix/issue
Dec 12, 2025
Merged

Fix: user request issue#14
up1512001 merged 2 commits intodevelopfrom
fix/issue

Conversation

@up1512001
Copy link
Copy Markdown
Member

What

  • due to missing trailingslash into shared sites url's were not matching and request was not reaching to brand site.

Related Issue(s):

Part of https://github.com/rtCamp/OnePress/issues/58

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • My code is tested to the best of my abilities.
  • My code passes all lints (ESLint etc.).
  • My code has detailed inline documentation.
  • I have updated the project documentation as needed.

@up1512001 up1512001 self-assigned this Dec 12, 2025
Copilot AI review requested due to automatic review settings December 12, 2025 08:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a URL matching issue where missing trailing slashes prevented requests from properly reaching brand sites. The fix normalizes URLs by removing trailing slashes before lookup operations.

  • Normalizes site URLs using untrailingslashit() before looking up in the shared sites array
  • Adds error logging for duplicate or invalid sites in update_user_roles_for_sites
  • Includes user data in the error response when an email already exists during user creation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread inc/Modules/Rest/Governing_Site_Controller.php Outdated
Comment thread inc/Modules/Rest/Governing_Site_Controller.php Outdated
Comment thread inc/Modules/Rest/Governing_Site_Controller.php Outdated
Comment thread inc/Modules/Rest/Governing_Site_Controller.php
@up1512001 up1512001 requested a review from justlevine December 12, 2025 09:30
@up1512001 up1512001 merged commit f88fe27 into develop Dec 12, 2025
9 checks passed
@up1512001 up1512001 deleted the fix/issue branch December 12, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants