Skip to content

Fix: duplicate site issue & PHP warning of undefined url#13

Merged
up1512001 merged 3 commits intodevelopfrom
fix/qa-issues
Dec 10, 2025
Merged

Fix: duplicate site issue & PHP warning of undefined url#13
up1512001 merged 3 commits intodevelopfrom
fix/qa-issues

Conversation

@up1512001
Copy link
Copy Markdown
Member

What

  • Fixes PHP undefined url warning of VIP dashboard
  • Fixes duplicate site selection issue

Related Issue(s):

  • Part of // Todo once issue is created

Checklist

  • I have read the Contribution Guidelines.
  • I have read the Development Guidelines.
  • My code is tested to the best of my abilities.
  • My code passes all lints (ESLint etc.).
  • My code has detailed inline documentation.
  • I have updated the project documentation as needed.

@up1512001 up1512001 requested a review from justlevine December 10, 2025 07:23
@up1512001 up1512001 self-assigned this Dec 10, 2025
Copilot AI review requested due to automatic review settings December 10, 2025 07:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix two issues: a PHP undefined url warning in the VIP dashboard and a duplicate site selection problem. The changes involve adding validation logic in PHP and normalizing URLs by removing trailing slashes in JavaScript to ensure consistent URL matching.

Key Changes:

  • Added check for url existence in brand validation (Settings.php)
  • Normalized URLs by removing trailing slashes to fix duplicate site detection (SharedUsers.js)
  • Clear password state when opening "Add to Sites" modal (SharedUsers.js)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
inc/Modules/Settings/Settings.php Added validation to check if url key exists in brand array before accessing it
assets/src/components/SharedUsers.js Normalized URLs by stripping trailing slashes to fix duplicate site matching, and added password state clearing in modal handler

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread assets/src/components/SharedUsers.js Outdated
Comment thread inc/Modules/Settings/Settings.php Outdated
Comment thread inc/Modules/Settings/Settings.php Outdated
Copilot AI review requested due to automatic review settings December 10, 2025 10:09
@up1512001 up1512001 requested a review from justlevine December 10, 2025 10:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@up1512001 up1512001 requested review from Copilot and removed request for Copilot December 10, 2025 10:15
@up1512001 up1512001 merged commit 23d2c83 into develop Dec 10, 2025
21 checks passed
@justlevine justlevine deleted the fix/qa-issues branch February 20, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants