Fix: duplicate site issue & PHP warning of undefined url#13
Merged
Fix: duplicate site issue & PHP warning of undefined url#13
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix two issues: a PHP undefined url warning in the VIP dashboard and a duplicate site selection problem. The changes involve adding validation logic in PHP and normalizing URLs by removing trailing slashes in JavaScript to ensure consistent URL matching.
Key Changes:
- Added check for
urlexistence in brand validation (Settings.php) - Normalized URLs by removing trailing slashes to fix duplicate site detection (SharedUsers.js)
- Clear password state when opening "Add to Sites" modal (SharedUsers.js)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
inc/Modules/Settings/Settings.php |
Added validation to check if url key exists in brand array before accessing it |
assets/src/components/SharedUsers.js |
Normalized URLs by stripping trailing slashes to fix duplicate site matching, and added password state clearing in modal handler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justlevine
reviewed
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justlevine
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
urlwarning of VIP dashboardRelated Issue(s):
Checklist