Skip to content

Fixes phpcs errors and warnings #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 23, 2019
Merged

Fixes phpcs errors and warnings #225

merged 4 commits into from
Dec 23, 2019

Conversation

chandrapatel
Copy link
Contributor

No description provided.

thrijith
thrijith suggested changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@thrijith thrijith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandrapatel minor query with JS files.

@chandrapatel @thrijith
Update phpcs.xml to scan JS files
d946b20 
Co-Authored-By: Thrijith Thankachan <thrijith13@gmail.com>
@chandrapatel
Copy link
Contributor Author

@chandrapatel minor query with JS files.

@thrijith I have committed suggested changes.

@thrijith
Update arg comment in ruleset
ec91292 
Whitelist and ignore `append` usage in JS
@chandrapatel chandrapatel merged commit c3632f5 into master Dec 23, 2019
@chandrapatel chandrapatel deleted the fix/phpcs-issues branch December 23, 2019 15:19
@chandrapatel chandrapatel mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrijith thrijith thrijith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandrapatel @thrijith