PHP Notice

[zanematthew]

On the initial loading of the settings there a PHP notice for an undefined index when "Enable Logging" is not set. However if you set-it, save the settings, the notice goes away, then you can uncheck the box again, and the notice is no longer present.

It seems the sane options approach as required in theme options/settings is not being used.

[rahul286]

@zanematthew I think this is fixed in - #99

Can you please confirm?

[zanematthew]

Looking into this...

[zanematthew]

@rahul286 Yep this issue no longer happens.

Although I did notice that the default options are written to the database during plugin install, rather than using the sane option approach mentioned in the link above.

That means that Themes must not write default setting values to the database

Honestly this probably isn't a big deal, btw great plugin!

[rahul286]

That means that Themes must not write default setting values to the database

I wholeheartedly agree with that. The current codebase is developed by 20+ people so it's slightly messy.

We will try our best to follow above and other coding practices during major refactoring.

Thanks.

[zanematthew]

I could imagine.