feat: project type filter in resource view #889
Open
wreckage0907 wants to merge 3 commits intodevelopfrom
Open
feat: project type filter in resource view #889wreckage0907 wants to merge 3 commits intodevelopfrom
wreckage0907 wants to merge 3 commits intodevelopfrom
Conversation
Collaborator
|
@wreckage0907 resolve conflicts |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds project type as a first-class filter in Resource Management Team and Timeline views, wiring it through the frontend filter state/query params and into the backend allocation queries.
Changes:
- Backend: accept
project_typeonget_resource_management_team_view_dataand apply it while fetching resource allocations. - Frontend: add
projectTypeto filter models/state, add a “Project Type” header filter, and includeproject_typein API request bodies. - Types/state: extend shared TS types and context defaults to carry
projectType.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| next_pms/resource_management/api/utils/query.py | Adds project-type-based filtering for allocation queries (via resolving Project names and applying a project condition). |
| next_pms/resource_management/api/team.py | Plumbs project_type into team-view allocation retrieval. |
| frontend/packages/app/src/types/resource_management.ts | Extends allocation type to optionally include project_type. |
| frontend/packages/app/src/app/pages/resource-management/timeline/utils.ts | Includes projectType in Timeline view filter serialization. |
| frontend/packages/app/src/app/pages/resource-management/timeline/types.ts | Adds projectType to timeline filter props and project_type to the API body type. |
| frontend/packages/app/src/app/pages/resource-management/timeline/components/header/resourceTimLineHeaderSection.tsx | Adds “Project Type” filter UI + query param handling in Timeline header. |
| frontend/packages/app/src/app/pages/resource-management/timeline/ resourceTimeLine.tsx | Sends project_type in Timeline API calls and keeps allocations refreshed under the new filter. |
| frontend/packages/app/src/app/pages/resource-management/team/utils.ts | Includes projectType in Team view filter serialization. |
| frontend/packages/app/src/app/pages/resource-management/team/index.tsx | Sends project_type in Team API calls (including refresh-after-edit flow). |
| frontend/packages/app/src/app/pages/resource-management/team/components/table/resourceTeamTableBody.tsx | Formatting-only changes in table body component. |
| frontend/packages/app/src/app/pages/resource-management/team/components/header.tsx | Adds “Project Type” filter UI + includes it in saved view filters logic. |
| frontend/packages/app/src/app/pages/resource-management/store/types.ts | Adds projectType to Team filter types. |
| frontend/packages/app/src/app/pages/resource-management/store/timeLineContext.tsx | Initializes Timeline context filters with projectType and updates formatting. |
| frontend/packages/app/src/app/pages/resource-management/store/teamContext.tsx | Initializes Team default filters with projectType and minor refactor/formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resource management filtering capabilities by adding support for filtering by project type across the team and timeline contexts
Relevant Technical Choices
projectTypeas a filter option inResourceTeamFilters,OptionalResourceTeamFilters, andResourceAllocationTimeLineFilterProps, enabling users to filter resources and allocations by project type.ResourceTeamHeaderSectioncomponent to read and apply theproject-typequery parameter, ensuring the UI supports project type filtering. )omitfor cleaner filter extraction, and ensured that project type and other filters are correctly handled when saving or updating views. (ESLINT REACT FLAGGED THE ISSUE SO FIXED)Testing Instructions
Additional Information:
Screenshot/Screencast
Screen.Recording.2026-03-12.at.4.37.07.PM.mov
Checklist
Fixes #2692