Skip to content

Add industry filter to project page#715

Merged
niraj2477 merged 3 commits intodevelopfrom
feat/project-industry-filter
Aug 18, 2025
Merged

Add industry filter to project page#715
niraj2477 merged 3 commits intodevelopfrom
feat/project-industry-filter

Conversation

@Siddhantsingh1230
Copy link
Copy Markdown
Collaborator

Description

This PR adds new Industry filter to filter project data based on custom_industry field

Relevant Technical Choices

  • Update Project Header to add new filter Ui
  • Update Project context state to incorporate above changes

Testing Instructions

  • Go to NPMS
  • Open Project page
  • Try adding Industry filter

Additional Information:

None

Screenshot/Screencast

Industry.Filter.webm

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Addresses: https://github.com/rtCamp/erp-rtcamp/issues/2462

@Siddhantsingh1230 Siddhantsingh1230 changed the base branch from main to develop August 14, 2025 14:17
Copy link
Copy Markdown
Collaborator

@niraj2477 niraj2477 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does custom field already exists?

@Siddhantsingh1230
Copy link
Copy Markdown
Collaborator Author

does custom field already exists?

No, the field was added by rtCRM module
@niraj2477

@niraj2477
Copy link
Copy Markdown
Collaborator

please make it part of this app

@Siddhantsingh1230 Siddhantsingh1230 marked this pull request as draft August 18, 2025 08:40
@Siddhantsingh1230 Siddhantsingh1230 marked this pull request as ready for review August 18, 2025 08:41
@Siddhantsingh1230
Copy link
Copy Markdown
Collaborator Author

Siddhantsingh1230 commented Aug 18, 2025

Instead of adding custom_industry to the Next PMS module, I introduced a conditional check for the industry filter. This field is also required in NCRM for project creation when an Opportunity’s status changes to Won. To avoid duplicating the custom field, I’ve kept it centralized in rtCRM and only added the conditional check in NPMS.

@niraj2477

@niraj2477 niraj2477 merged commit d14cfec into develop Aug 18, 2025
5 checks passed
@niraj2477 niraj2477 deleted the feat/project-industry-filter branch February 13, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants