Playwright tests for Resource Management : Project Tab#707
Merged
Playwright tests for Resource Management : Project Tab#707
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Playwright end-to-end tests for the Resource Management Project Tab, implementing comprehensive test coverage for filtering functionality, sheet views, and navigation features.
- Introduces new Resource Management API utility for creating and deleting allocations
- Adds comprehensive test cases for project tab filters (customer, billing type, allocation type)
- Implements sheet view testing for Planned and Actual vs Planned views with combined weekly hours
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/utils/api/resourceManagementRequests.js | New API utility module for resource allocation operations |
| tests/e2e/specs/manager/resourceManagement/project.spec.js | New test file with comprehensive project tab test cases |
| tests/e2e/pageObjects/resourceManagement/project.js | Enhanced page object with filter methods and UI interactions |
| tests/e2e/helpers/resourceManagementHelpers.js | New helper module for allocation CRUD operations |
| tests/e2e/globals/globalSetup.js | Integration of allocation creation in test setup |
| tests/e2e/helpers/timesheetHelper.js | Updates to support project data and allocation handling |
| tests/e2e/data/manager/project.js | Test data additions for new project test cases |
Comments suppressed due to low confidence (3)
tests/e2e/utils/api/resourceManagementRequests.js:69
- The function name 'createAllocation' conflicts with the comment above it which says 'Create a new Project entry'. Either update the comment to reflect allocation creation or clarify the function's purpose.
export const createAllocation = async (payload) => {
tests/e2e/specs/manager/resourceManagement/project.spec.js:37
- This assertion expects the filtered list to be equal to the unfiltered list, which doesn't validate that the filter is working correctly. The test should verify that the filter actually filters the results.
expect(projectListAfterFilter).toEqual(projectListBeforeFilter);
tests/e2e/specs/manager/resourceManagement/project.spec.js:67
- Similar to TC73, this assertion expects the filtered and unfiltered lists to be equal, which doesn't properly test the filtering functionality.
expect(projectListAfterBillingFilter).toEqual(projectListBeforeBillingFilter);
jayson31
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relevant Technical Choices
Testing Instructions
Additional Information:
Pipeline execution result : https://github.com/rtCamp/next-pms/actions/runs/16778255272
Screenshot/Screencast
Checklist
Fixes #