Skip to content

Playwright tests for Resource Management : Project Tab#707

Merged
maharrshi merged 13 commits intodevelopfrom
test/automate/RM-projectTab
Aug 7, 2025
Merged

Playwright tests for Resource Management : Project Tab#707
maharrshi merged 13 commits intodevelopfrom
test/automate/RM-projectTab

Conversation

@maharrshi
Copy link
Copy Markdown
Collaborator

@maharrshi maharrshi commented Aug 1, 2025

Description

Relevant Technical Choices

Testing Instructions

Additional Information:

Pipeline execution result : https://github.com/rtCamp/next-pms/actions/runs/16778255272

Screenshot/Screencast

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes #

@maharrshi maharrshi changed the title Playwright tests for Resroucre Management : Project Tab Playwright tests for Resource Management : Project Tab Aug 4, 2025
@maharrshi maharrshi requested a review from Copilot August 6, 2025 13:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Playwright end-to-end tests for the Resource Management Project Tab, implementing comprehensive test coverage for filtering functionality, sheet views, and navigation features.

  • Introduces new Resource Management API utility for creating and deleting allocations
  • Adds comprehensive test cases for project tab filters (customer, billing type, allocation type)
  • Implements sheet view testing for Planned and Actual vs Planned views with combined weekly hours

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/e2e/utils/api/resourceManagementRequests.js New API utility module for resource allocation operations
tests/e2e/specs/manager/resourceManagement/project.spec.js New test file with comprehensive project tab test cases
tests/e2e/pageObjects/resourceManagement/project.js Enhanced page object with filter methods and UI interactions
tests/e2e/helpers/resourceManagementHelpers.js New helper module for allocation CRUD operations
tests/e2e/globals/globalSetup.js Integration of allocation creation in test setup
tests/e2e/helpers/timesheetHelper.js Updates to support project data and allocation handling
tests/e2e/data/manager/project.js Test data additions for new project test cases
Comments suppressed due to low confidence (3)

tests/e2e/utils/api/resourceManagementRequests.js:69

  • The function name 'createAllocation' conflicts with the comment above it which says 'Create a new Project entry'. Either update the comment to reflect allocation creation or clarify the function's purpose.
export const createAllocation = async (payload) => {

tests/e2e/specs/manager/resourceManagement/project.spec.js:37

  • This assertion expects the filtered list to be equal to the unfiltered list, which doesn't validate that the filter is working correctly. The test should verify that the filter actually filters the results.
    expect(projectListAfterFilter).toEqual(projectListBeforeFilter);

tests/e2e/specs/manager/resourceManagement/project.spec.js:67

  • Similar to TC73, this assertion expects the filtered and unfiltered lists to be equal, which doesn't properly test the filtering functionality.
    expect(projectListAfterBillingFilter).toEqual(projectListBeforeBillingFilter);

@maharrshi maharrshi marked this pull request as ready for review August 6, 2025 13:55
@maharrshi maharrshi requested a review from jayson31 August 6, 2025 13:55
@maharrshi maharrshi merged commit d5dd73d into develop Aug 7, 2025
7 checks passed
@maharrshi maharrshi deleted the test/automate/RM-projectTab branch August 7, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants