Fix row creation in empty child table & add min-width to childtable ui#695
Merged
Fix row creation in empty child table & add min-width to childtable ui#695
Conversation
niraj2477
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes row creation in the Project Detail page when the child table is initially empty.
The issue was caused by using
rows[rows.length - 1].idx + 1, which fails when rows is an empty array, as rows[-1] is undefined. This PR also adds a minimum width to the child table to ensure better accessibility and usability on smaller screens.Relevant Technical Choices
newIdxbased on array length, if length is zero assign1to the new rowTesting Instructions
Additional Information:
Screenshot/Screencast
Before:
Add.Row-1753272231002.mp4
After:
Fix.Child.table.-1753272061638.mp4
Checklist