fix(deps): resolve Dependabot security alerts via overrides#1894
Open
subodhr258 wants to merge 2 commits into
Open
fix(deps): resolve Dependabot security alerts via overrides#1894subodhr258 wants to merge 2 commits into
subodhr258 wants to merge 2 commits into
Conversation
Bumps direct deps and pins transitive vulnerable packages to their patched versions to address open Dependabot alerts on the repository: - axios 1.7.x → 1.16.1 (CRLF/SSRF/prototype-pollution suite) - uuid 11.0.5 → 11.1.1 (missing buffer bounds check) - postcss 8.4.x → 8.5.15 (CSS stringify XSS) - qs → 6.15.2 (DoS in qs.stringify) - protobufjs → 7.5.8 (RCE/DoS/prototype-pollution) - @protobufjs/utf8 → 1.1.1 (overlong UTF-8 decoding) - ws → 8.20.1 (uninitialized memory disclosure) - webpack-dev-server → 5.2.4 (cross-origin source exposure) - @babel/plugin-transform-modules-systemjs → 7.29.4 (arbitrary code generation) - fast-uri → 3.1.2 (host confusion + path traversal) - simple-git → 3.36.0 (RCE) - ip-address → 10.1.1 (Address6 XSS) - dompurify → 3.4.5 (SAFE_FOR_TEMPLATES/FORBID_TAGS bypass) - follow-redirects → 1.16.0 (auth-header leak on cross-domain redirect) Showdown remains pinned at 2.1.0 since upstream has not published a patched release for the ReDoS advisory (GHSA-rmmh-p597-ppvv). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (3)📁 readme.txt (1 error)
📁 lib/class-godam-frappe-dispatch-installer.php (2 errors)
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 composer.json (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
missing_composer_json_file | The "/vendor" directory using composer exists, but "composer.json" file is missing. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/05/26/demo-post-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-page-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/05/26/demo-post-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-page-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve the repository’s Dependabot security alerts by pinning patched dependency versions—primarily via package.json overrides (plus a few direct dependency bumps)—and updating package-lock.json accordingly.
Changes:
- Bump direct dependencies to patched versions (
axios,uuid,postcss). - Add/expand
overridespins for multiple vulnerable transitive packages (e.g.,protobufjs,qs,ws,webpack-dev-server,dompurify, etc.). - Refresh
package-lock.jsonto reflect the new dependency graph and patched resolutions.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Pins patched direct deps and adds/updates overrides entries to force secure transitive versions. |
| package-lock.json | Updates the resolved dependency tree to incorporate the new pins/overrides and patched packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses Copilot review feedback on #1894. The unscoped overrides "uuid": "11.1.1" and "ws": "8.20.1" were force-downgrading consumers that legitimately depend on newer non-vulnerable majors: - Four @wordpress/* subtrees declare uuid: ^14.0.0; the unscoped override was pulling them down to 11.1.1, which risks API mismatch since uuid v13+ became ESM-only with restructured exports. - puppeteer-core (via lighthouse) pulls ws 8.21.0, which is already past the vulnerable range (>= 8.0.0, < 8.20.1); the unscoped pin was an unnecessary downgrade. Switching to range-scoped overrides: "uuid@<11.1.1": "11.1.1" "ws@<8.20.1": "8.20.1" After re-resolve: - uuid: 11.1.1 (top-level) + 14.0.0 (newer WP subtrees) — both patched - ws: 8.20.1 (top-level) + 8.21.0 (puppeteer-core) — both patched `npm run build:prod` still compiles all entrypoints cleanly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the open Dependabot security alerts on the repository. All fixes are scoped to
package.jsonoverrides(and direct deps where applicable) — no source code or build artifacts changed.Resolved alerts
axiosuuidpostcssqsprotobufjs@protobufjs/utf8wswebpack-dev-server@babel/plugin-transform-modules-systemjsfast-urisimple-gitip-addressdompurifyfollow-redirectsNot fixed
showdown(transitive via@wordpress/blocks) — upstream has not published a patched release for GHSA-rmmh-p597-ppvv.fixed_inisnullin the Dependabot alert. This one will remain open until WordPress drops showdown or upstream publishes a fix.Approach
Most flagged packages are transitive deps locked behind WordPress /
@wordpress/scriptsmajor versions. Rather than force-bumping multiple WP packages to majors, the patched versions are pinned viaoverridesinpackage.json. Existing override entries forprotobufjs,webpack-dev-server, andmonaco-editor.dompurifywere bumped to current patched versions; the redundant monaco-scopeddompurifyoverride was replaced by a top-level one that also coversisomorphic-dompurify.npm auditafter the change confirms each of the Dependabot-flagged packages now resolves to its patched version inpackage-lock.json.Risk surface — where each bump can break things
axios(+follow-redirects,qs,ip-address,fast-uri)pages/tools/components/tabs/RetranscodeTab.jsx,pages/tools/components/tabs/Migration/{VimeoVideoMigration,CoreVideoMigration,MigrationTab}.jsx,pages/analytics/Analytics.jsuuidpages/video-editor/components/SidebarLayers.js,pages/video-editor/components/chapters/Chapters.js,pages/video-editor/components/layers/HotspotLayer.jsdompurify(top-level, used viaisomorphic-dompurifyand insidemonaco-editor)assets/src/js/godam-gallery.js,assets/src/js/godam-player/managers/{playerManager,shareManager}.js,assets/src/js/godam-player/masterSettings.js. Integrations:assets/src/js/gravity-form/gf-godam-recorder-editor.js,assets/src/js/lifterlms/{block,embed}.js. Admin:assets/src/js/media-library/views/attachment-detail-two-column.jsFORBID_TAGS/SAFE_FOR_TEMPLATEShandling, so any HTML that previously slipped through (custom tags, namespaced attrs) may now be strippedmonaco-editor(viadompurify3.4.5)pages/godam/components/tabs/VideoPlayer/CustomVideoPlayerCSS.jsx,pages/video-editor/components/layers/FormLayer.js,pages/video-editor/components/layers/PollLayer.js,pages/video-editor/components/cta/HtmlCTA.jsprotobufjs,@protobufjs/utf8posthog-js/@opentelemetry/*— pulled in by every page that importspages/utils/posthog.js(dashboard, godam, media-library, tools, video-editor, help, whats-new)/i/capture calls)postcss(8.4 → 8.5).cssfiles between develop and this branch to spot any unexpected output change@babel/plugin-transform-modules-systemjsws,webpack-dev-server,simple-gitnpm start/ HMR / lint-stagedTest plan
Automated
npm installresolves cleanly with the new overridesnpm run build:prodcompiles all entrypoints (webpack 5.105.4, all bundles emitted)package-lock.json(axios 1.16.1, uuid 11.1.1, postcss 8.5.15, qs 6.15.2, protobufjs 7.5.8, @protobufjs/utf8 1.1.1, ws 8.20.1, webpack-dev-server 5.2.4, @babel/plugin-transform-modules-systemjs 7.29.4, fast-uri 3.1.2, simple-git 3.36.0, ip-address 10.1.1, dompurify 3.4.5, follow-redirects 1.16.0)npm startboots webpack-dev-server 5.2.4 without HMR regressionManual smoke — admin / WP wp-admin
<style>, custom attributes, and a<script>(should be stripped) — verify dompurify 3.4 sanitization output matches expectations/i/v0/e/or equivalent capture calls succeed (200) — no protobuf serialization errors in consoleIntegrations
Rollback
npm install— no migrations, no schema changes, no PHP side effects.🤖 Generated with Claude Code — Opus 4.7