feat: Reel Pop analytics — SDK page_load_session_id + Dashboard table#1890
Open
subodhr258 wants to merge 8 commits into
Open
feat: Reel Pop analytics — SDK page_load_session_id + Dashboard table#1890subodhr258 wants to merge 8 commits into
subodhr258 wants to merge 8 commits into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
…elope Co-Authored-By: Claude <noreply@anthropic.com>
…1/2 attribution Co-Authored-By: Claude <noreply@anthropic.com>
…sent Co-Authored-By: Claude <noreply@anthropic.com>
….RTGodamAnalyticsHelpers for cross-plugin reuse Co-Authored-By: Claude <noreply@anthropic.com>
Proxies the godam-analytics /reel-pops/summary endpoint, injecting the API key + account token server-side and enriching each row with the WP post title / thumbnail / edit URL for the dashboard table. Co-Authored-By: Claude <noreply@anthropic.com>
Single apiFetch on mount renders one row per Reel Pop with four cumulative counters (Impressions / Engagement / Closure / Conversion). Thumbnail + title click-through to the editor; matches existing top-videos pagination and styling. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
rtBot
requested changes
May 25, 2026
Contributor
rtBot
left a comment
rtBot
left a comment
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 1 error
Powered by rtCamp's GitHub Actions Library
| $url, | ||
| array( | ||
| 'headers' => array( 'X-API-Key' => $api_key ), | ||
| 'timeout' => 5, |
Contributor
There was a problem hiding this comment.
🚫 Error: Detected high remote request timeout. timeout is set to 5 (WordPressVIPMinimum.Performance.RemoteRequestTimeout.timeout_timeout).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Reel Pop analytics support end-to-end: a per-page-load UUID (page_load_session_id) included in player analytics envelopes for deduping, exposes SDK helper functions for other plugins, and introduces a new Dashboard “Reel Pops” summary table backed by a server-side REST proxy that injects the API key.
Changes:
- Player analytics: generate/reuse
page_load_session_id, optionally includereel_pop_id, and propagate Reel Pop attribution through the tracking paths. - SDK interop: expose
window.RTGodamAnalyticsHelperswithgetPageLoadSessionId()andgetUserAgent(). - Dashboard: add a REST proxy endpoint for
/dashboard/reel-pops-summaryand a new React table component rendering cumulative Reel Pop counters.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pages/dashboard/Dashboard.js | Mounts the new Reel Pops table in the Dashboard UI. |
| pages/dashboard/components/ReelPopsTable.jsx | Fetches and renders the Reel Pops summary table with pagination/error/loading states. |
| inc/classes/rest-api/class-dashboard.php | Adds REST proxy endpoint to fetch/caches Reel Pops summary and enriches rows with WP metadata. |
| inc/classes/class-plugin.php | Registers the new Dashboard REST controller. |
| assets/src/js/godam-player/video-analytics-plugin.js | Forwards reel_pop_id from track properties into request-body builder. |
| assets/src/js/godam-player/analytics.js | Adds optional reelPopId propagation and exposes helper functions on window. |
| assets/src/js/godam-player/analytics-helpers.js | Implements getPageLoadSessionId() and adds page_load_session_id / optional reel_pop_id to the analytics envelope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+25
to
+33
| if ( window.crypto?.randomUUID ) { | ||
| _pageLoadSessionId = window.crypto.randomUUID(); | ||
| return _pageLoadSessionId; | ||
| } | ||
| // Fallback for older browsers. | ||
| const bytes = window.crypto.getRandomValues( new Uint8Array( 16 ) ); | ||
| bytes[ 6 ] = ( bytes[ 6 ] & 0x0f ) | 0x40; // version 4 | ||
| bytes[ 8 ] = ( bytes[ 8 ] & 0x3f ) | 0x80; // variant 10 | ||
| const hex = Array.from( bytes, ( b ) => b.toString( 16 ).padStart( 2, '0' ) ).join( '' ); |
Comment on lines
+89
to
+94
| $endpoint = defined( 'RTGODAM_ANALYTICS_BASE' ) ? RTGODAM_ANALYTICS_BASE : 'https://analytics.godam.io'; | ||
| $api_key = get_option( 'rtgodam-api-key', '' ); | ||
| $account_token = get_option( 'rtgodam-account-token', 'unverified' ); | ||
| $site_url = home_url(); | ||
| $from = $request->get_param( 'from' ); | ||
| $to = $request->get_param( 'to' ); |
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (3)📁 readme.txt (1 error)
📁 lib/class-godam-frappe-dispatch-installer.php (2 errors)
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 composer.json (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
missing_composer_json_file | The "/vendor" directory using composer exists, but "composer.json" file is missing. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/05/25/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/05/25/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin-side counterpart to the already-merged godam-analytics PR #140. Adds a per-page-load UUID v4 (
page_load_session_id) to every type=1/2/3 analytics envelope so the microservice can dedup engagement counters withuniqExact(page_load_session_id), keeping derived rates (Engagement / Impressions etc.) bounded ≤ 100%. Exposes godam SDK helpers onwindow.RTGodamAnalyticsHelpersso godam-for-woo can emit identical normalized UA strings + share the per-page-load session ID for its type=4 (Reel Pop) events. Adds a new "Reel Pops" cumulative table to the GoDAM Dashboard backed by a server-side REST proxy that injectsX-API-Keyso the browser never sees the key.SDK changes (
assets/src/js/godam-player/)analytics-helpers.js: newgetPageLoadSessionId()(UUID v4 with crypto.randomUUID + hand-rolled fallback for mobile Safari < 15.4); added tobuildAnalyticsRequestBodyenvelope.analytics-helpers.js:buildAnalyticsRequestBodynow accepts optionalreelPopIdand only writesreel_pop_idto the body when > 0 — non-Reel-Pop events stay at the same wire shape.analytics.js:trackVideoEventaccepts optionalreelPopIdand propagates it onto both the auto type=1page_loadpayload and the type=2video_heatmappayload.analytics.js:sendPlayerHeatmap(the unload-flush keepalive path) readsdata-reel-pop-idoff the<video>element and forwards it on type=2 events. The SDK itself doesn't know what a Reel Pop is — this just opaquely propagates the attribute.analytics.js: exposeswindow.RTGodamAnalyticsHelpers = { getPageLoadSessionId, getUserAgent }so godam-for-woo (and future plugins) can call them without pollutingwindow.analytics(which is the Analytics library instance).video-analytics-plugin.js: forwardsreel_pop_idfromtrack()properties intobuildAnalyticsRequestBody.Dashboard changes
inc/classes/rest-api/class-dashboard.php:GET /godam/v1/dashboard/reel-pops-summary— proxies the microservice/reel-pops/summaryendpoint withX-API-Keyinjected server-side, enriches each row with the WP post title / thumbnail / edit URL, drops rows whose post no longer exists or isn't published, caches the upstream response for 60 s.inc/classes/class-plugin.php::load_rest_api().pages/dashboard/components/ReelPopsTable.jsx: singleapiFetchon mount; renders one row per Reel Pop with Impressions / Engagement / Closure / Conversion counters; thumbnail + title click-through to the editor; matches the existing top-videos table styling and pagination pattern.<ReelPopsTable />inDashboard.jsbelow the existing top-videos table.Companion PRs
Test plan
npm run build:prodcompletes without errors.page_load_session_id,RTGodamAnalyticsHelpers,reel_pop_idstrings appear in the minifiedgodam-player-analytics.min.jsbundle.reel-pops-summary+reel_pop_idstrings appear in the minifieddashboard.min.jsbundle.subodh-multisite.rt.gw:page_load_session_id(DevTools Network → request payload).window.RTGodamAnalyticsHelpers.getPageLoadSessionId()returns the same UUID across multiple calls on one page load.🤖 Generated with Claude Code