This repository was archived by the owner on Oct 27, 2020. It is now read-only.
Fixed error when there was no label set in config #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't need to work on other languages, so my opinion should not matter on this. |
rahul286
added a commit
that referenced
this pull request
May 12, 2015
Fixed error when there was no label set in config
|
I will check that in our multilanguage book and post any updates if any errors occur :) |
|
@aniav Thanks. :-) Please check with v1.4.1 (latest as of now). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about that. I had that fixed in my local code but somehow it did not get committed :-(
Also a question: Currently, if you do define a label for some but not all languages of your book, that could result in an error or strange output. Do you think we need to cover that? If so I'll add it to this PR.