Conversation
There was a problem hiding this comment.
Pull request overview
Adds tighter dependency constraints for frappe via Bench configuration and updates the Semgrep pre-commit hook revision to a newer release.
Changes:
- Added
[tool.bench.frappe-dependencies]with an explicitfrappeversion range. - Bumped
semgrep/pre-commithookrevfromv1.91.0tov1.150.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Introduces Bench-managed frappe version constraints. |
| .pre-commit-config.yaml | Updates the Semgrep pre-commit hook version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niraj2477
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configuration change to the
pyproject.tomlfile, specifically adding a version constraint for thefrappedependency. This ensures that the project will only use compatible versions of thefrappepackage.Dependency management:
[tool.bench.frappe-dependencies]section to specify that thefrappepackage version must be between 15.0.0 and 16.0.0, improving dependency control and compatibility.ModuleNotFoundError: No module named 'pkg_resources'error