Feature: Add admin logo & fix PHPCS issues #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an admin logo to the OneDesign plugin and addresses multiple PHPCS (PHP CodeSniffer) compliance issues by updating comment formatting and improving code structure.
- Replaced the default generic dashicon with a custom logo for the admin menu
- Fixed PHPCS violations by adding periods to comments and improving variable handling
- Added admin CSS styling to display the custom logo in the WordPress admin menu
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inc/classes/class-settings.php | Removed default dashicon and fixed comment formatting/variable handling |
| inc/classes/class-rest.php | Updated comment formatting to comply with PHPCS standards |
| inc/classes/class-assets.php | Added admin script enqueuing functionality for the new admin styles |
| assets/src/css/admin.scss | Added CSS rules to display custom logo in the admin menu |
up1512001
changed the title
danish17
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds custom branding to the WordPress admin interface and improves code quality.
Changes Made
Testing
Screenshot