fix: change settings page position #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
parthnvaswani
commented
Aug 11, 2025
parthnvaswani
commented
- Moves settings page to second position in onedesign submenu.
- Adds link to settings page in the design library editor.
rtBot
previously requested changes
Aug 11, 2025
rtBot
left a comment
rtBot
left a comment
There was a problem hiding this comment.
Code analysis identified issues
action-phpcs-code-review has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 1 error
Powered by rtCamp's GitHub Actions Library
rtBot
dismissed
their stale review
Dismissing review as all inline comments are obsolete by now
danish17
approved these changes
Aug 11, 2025
Comment on lines
+467
to
+479
| isLoading={ isLoading } | ||
| basePatterns={ filteredBasePatterns } | ||
| visibleCount={ visibleCount } | ||
| handlePatternSelection={ handlePatternSelection } | ||
| hasMorePatterns={ hasMorePatterns } | ||
| loadMorePatterns={ loadMorePatterns } | ||
| searchTerm={ searchTerm } | ||
| setSelectedPatterns={ setSelectedPatterns } | ||
| selectedPatterns={ selectedPatterns } | ||
| applySelectedPatterns={ applySelectedPatterns } | ||
| consumerSites={ consumerSites } | ||
| sitePatterns={ allConsumerSitePatterns } | ||
| /> |
Collaborator
There was a problem hiding this comment.
Better to pass a single options prop instead of passing so many props separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.