Skip to content

Conversation

@up1512001
Copy link
Member

  • Added an admin notice for cases when someone clones directly from the GitHub repository, providing better guidance and avoiding fatal error.
  • Loaded the plugin on the plugins_loaded hook.
  • Added an uninstall.php file to clean up options after the plugin is deleted.
  • Removed unused packages server-side-render and block-serialization-default-parser.
  • Added translations file.
  • Fix linting issues.
Screenshot 2025-08-18 at 16 03 23

@up1512001 up1512001 self-assigned this Aug 18, 2025
@up1512001 up1512001 requested review from Copilot and danish17 August 18, 2025 10:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs maintenance tasks to improve the OneDesign plugin's installation experience and clean up unused dependencies. It addresses issues that could occur when users clone the plugin directly from GitHub and ensures proper cleanup when the plugin is uninstalled.

  • Added comprehensive installation guidance for GitHub repository clones with admin notices
  • Implemented proper plugin lifecycle management with uninstall cleanup and hooks optimization
  • Removed unused WordPress dependencies and added translation support

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uninstall.php New file that cleans up plugin options when the plugin is deleted
package.json Removes unused WordPress packages (block-serialization-default-parser and server-side-render)
onedesign.php Adds GitHub clone detection with admin notice and moves plugin loading to plugins_loaded hook
languages/onedesign.pot New translation file containing all translatable strings
inc/classes/class-plugin.php Refactors constructor to use separate setup method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@up1512001 up1512001 merged commit 536d581 into main Aug 18, 2025
5 checks passed
@up1512001 up1512001 deleted the chore/refactor-plugin branch October 13, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants