Update build install script name to match the current situation #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiryoh
added
the
Type: Refactoring
ShotaAk
reviewed
Oct 27, 2021
| # build and install the driver | ||
| cd $SRC_DIR/src/drivers/ | ||
| rm Makefile | ||
| ln -s Makefile.header_from_apt Makefile |
There was a problem hiding this comment.
意図した差分が出ていないので、コメントで補足。
このファイルは旧build_install.ubunt14.bashの名前を変えたもので、
差分は11行目のln -s Makefile.ubuntu14 Makefileからln -s Makefile.header_from_apt Makefileへの変更のみ。
ShotaAk
reviewed
Oct 27, 2021
| # build and install the driver | ||
| cd $SRC_DIR/src/drivers/ | ||
| rm Makefile | ||
| ln -s Makefile.header_from_source Makefile |
There was a problem hiding this comment.
意図した差分が出ていないので、コメントで補足。
このファイルは旧build_install.raspbian.bashの名前を変えたもので、
差分は11行目のln -s Makefile.raspbian Makefileからln -s Makefile.header_from_source Makefileへの変更のみ。
ShotaAk
reviewed
Oct 27, 2021
Comment on lines
+13
to
+14
| # Update for Raspberry Pi 4 | ||
| sed -i -e "s/#define RASPBERRYPI 2/#define RASPBERRYPI 4/g" rtmouse.c |
There was a problem hiding this comment.
コメントで補足。
このファイルと、build_install_header_from_source_raspi2.bashの差分は13, 14行目のみ。
ShotaAk
approved these changes
Oct 27, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
現状のインストールスクリプトには"raspbian"や"ubuntu"のようなキーワードが含まれ、OSによってスクリプトを使い分けるように見受けられます。
しかしながら実際にはLinuxカーネルのヘッダファイルのインストール方法によってスクリプトが使い分けられているため、現状にあわせた名前に変更します。
この変更後もビルドする際は
utils/build_install.bashを実行するのみで、ほとんどのユーザの操作は変わりません。The current installation script file name includes keywords such as "raspbian" and "ubuntu" and seems to be separate for different operating systems.
However, the scripts are separated according to the installation method of the linux header file, so this PR renames them to match the current situation.
Most users will still only need to run
utils/build_install.bashto build.build_install.raspi4ubuntu.bashbuild_install_header_from_apt_raspi4.bashbuild_install.ubuntu14.bashbuild_install_header_from_apt_raspi2.bashbuild_install.raspbian.bashbuild_install_header_from_source_raspi2.bashbuild_install_header_from_source_raspi4.bashDoes this close any currently open issues?
No
How has this been tested?
以下の構成で実行されるスクリプト名を確認しました。
Checked the script name to be executed in the following configuration.
build_install_header_from_apt_raspi4.bashbuild_install_header_from_apt_raspi4.bashbuild_install_header_from_apt_raspi2.bashbuild_install_header_from_apt_raspi2.bashbuild_install_header_from_source_raspi2.bashbuild_install_header_from_source_raspi4.bashAny other comments?
Checklists