Skip to content

[BUG] remove trailing backslash #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isabelizimm merged 1 commit into from
Oct 27, 2023
Merged

[BUG] remove trailing backslash #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vetiver/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,4 +370,8 @@ def vetiver_endpoint(url: str = "http://127.0.0.1:8000/predict") -> str:
>>> import vetiver
>>> endpoint = vetiver.vetiver_endpoint(url='http://127.0.0.1:8000/predict')
"""
# remove trailing backslash, if it exists
if url[-1] == "/":
url = url[:-1]

return url
8 changes: 8 additions & 0 deletions vetiver/tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
VetiverAPI,
vetiver_create_prototype,
InvalidPTypeError,
vetiver_endpoint,
)
from pydantic import BaseModel, conint
from fastapi.testclient import TestClient
Expand Down Expand Up @@ -117,3 +118,10 @@ def test_complex_prototype(complex_prototype_model):

with pytest.raises(InvalidPTypeError):
vetiver_create_prototype(response.json())


def test_vetiver_endpoint():
url_raw = "http://127.0.0.1:8000/predict/"
url = vetiver_endpoint(url_raw)

assert url == "http://127.0.0.1:8000/predict"