update ptype_data to prototype_data
#138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelizimm
commented
Dec 14, 2022
juliasilge
reviewed
Dec 15, 2022
Member
juliasilge
left a comment
juliasilge
left a comment
There was a problem hiding this comment.
I noticed a couple of things that I had questioned about, but looking great! 🙌
has2k1
requested changes
Dec 16, 2022
Collaborator
has2k1
left a comment
has2k1
left a comment
There was a problem hiding this comment.
Summary, two main points.
- Any reference to ptype should be associated with the deprecated name.
- Tackle the other confusion that the ptype (now prototype) is also "model".
has2k1
reviewed
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in parity with rstudio/vetiver-r#84 and rstudio/vetiver-r#166
This PR deprecates the
ptype_dataargument in favor ofprototype_data.Will result in:
Deprecation warning: argument for saving input data prototype has changed to save_prototype, from save_ptypeThe argument name change is not reflected in functions such as
vetiver_create_ptypethat are almost exclusively used in programmatic model creation.