New prepare_docker function
#137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Related to rstudio/vetiver-r#165 I think we are landing on the right way forward here; when you feel pretty confident about this, let me know and I'll finish up my PR as well! 🙌 |
Contributor
Author
|
@juliasilge this feels like it's at a pretty good place! |
juliasilge
approved these changes
Dec 7, 2022
Member
juliasilge
left a comment
juliasilge
left a comment
There was a problem hiding this comment.
This looks great! 🙌 Glad we landed on something that we feel good about.
I'm going to merge rstudio/vetiver-r#165 as soon as I get the pkgdown problem sorted, so let's call this PR good to go 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this function would create all files needed for Docker, combining
write_appandwrite_docker.Currently, it also creates a minimal requirements.txt for the deployment (make it optional?)