BUG, MAINT: Catch non 200 codes #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Honestly one thing lead to another and here is what I ended up doing:
1.1. In the case of a 422, raise a
TypeError(same as before), but without all the extra processing. Now I'm pretty sure (take this with a pinch of salt :)) the status code check is sufficient, we need not check the json for type error1.2. In case of every other error, raise an
HTTPErrorwith a meaningful error messageifand some more test cases for theTypeErrorExample:
Before:
Now:
resolves: #71
PS: Totally fine with getting rid of the extra stuff and just fixing the error, 81818dd does that.