Skip to content

Conversation

@ganesh-k13
Copy link
Contributor

@ganesh-k13 ganesh-k13 commented Nov 19, 2022

Changes

  • Added missing model_name to VetiverModel in README

As per

model_name: str,
model_name is not optional, hence example for failing.

Traceback (most recent call last):   
  File "/home/ganesh/os/mlops/vetiver-python/hostt.py", line 8, in <module>
    v = VetiverModel(model, save_ptype=True, ptype_data=X)                                                                                                                                                                            
TypeError: VetiverModel.__init__() missing 1 required positional argument: 'model_name'

Copy link
Contributor

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you for this 🙌 looks perfect!

@isabelizimm isabelizimm merged commit f2752dc into rstudio:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants