Skip to content

Conversation

@isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Aug 23, 2022

closes #27

TODO:

  • research serialization of xgboost.DMatrix for predict
    ⬆️ Users are able to post a pd.DataFrame for vetiver to do the handling into an xgboost.DMatrix for prediction.

@isabelizimm isabelizimm requested review from machow and removed request for machow August 24, 2022 21:49
@isabelizimm isabelizimm marked this pull request as ready for review August 25, 2022 16:30
@isabelizimm isabelizimm requested a review from machow August 25, 2022 16:32
Copy link
Contributor

@machow machow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM w/ Hassan's comments! I wonder if there's a good place to let people find handlers from the docs? (either a written list of which packages are supported, or a list of handlers?)

image

@isabelizimm
Copy link
Contributor Author

I wonder if there's a good place to let people find handlers from the docs? (either a written list of which packages are supported, or a list of handlers?)

Good point! I added another tab "Model Types" and updated the front page to reflect what is supported

@isabelizimm isabelizimm merged commit 7202cd8 into main Aug 26, 2022
@isabelizimm isabelizimm deleted the xgboost branch August 26, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support xgboost models

3 participants