Skip to content

Conversation

@isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Aug 19, 2022

TODO

  • add tests/handling for no ptype predictions
  • check edge cases around statsmodels.base.wrapper.ResultsWrapper (right now, this seems to work with most models that have a predict method)

@isabelizimm isabelizimm added the enhancement New feature or request label Aug 19, 2022
@isabelizimm isabelizimm marked this pull request as ready for review August 22, 2022 22:51
a trained and fit statsmodels model
"""

model_class = staticmethod(lambda: statsmodels.base.wrapper.ResultsWrapper)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for models with a predict method, using this class seems to be sufficient to identify statsmodels models

@isabelizimm isabelizimm merged commit 22405bd into main Aug 23, 2022
@isabelizimm isabelizimm deleted the statsmodels branch August 23, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

1 participant