Skip to content

Inconsistent use of full stop in error messages  #79

@stefanoborini

Description

@stefanoborini

Trivial thing, but it bugs me a lot because users get inconsistent writing style for the error messages they receive

in sv_gte, the message has a full stop at the end of the message:

message_fmt = "Must be greater than {rhs}.",

in sv_integer, there's no full stop

https://github.com/rstudio/shinyvalidate/blob/1c642658b341b1413aa7c4fd766cc53ced0cc7b6/R/rules.R#L576C1-L576C1

These two are examples. The issue is pretty much all over the place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions